ANGLE support #1017

Alovchin91 · 2025-01-30T09:41:13Z

This change adds ANGLE renderer support to Skiko.

ANGLE project translates OpenGL ES API calls to the native platform's graphics API. This is mostly useful on Windows where ANGLE provides the Direct3D 11 backend.

Right now, there is a gap in Skiko's graphics support. On Windows ARM, Skia doesn't support OpenGL yet. At the same time, some GPUs, like Parallels or VMware virtual GPUs, don't support DirectX 12. This means Skiko falls back to the slow software rendering on those GPUs. ANGLE solves this problem by providing an easy-to-use DirectX 11 backend.

In addition, ANGLE is used by Chromium-based browsers and apps, so we expect it to be more stable than Skia's DirectX backend.

skiko/buildSrc/src/main/kotlin/properties.kt

igordmn · 2025-01-31T13:02:07Z

skiko/build-with-local-skia.sh

@@ -43,7 +43,7 @@ case $SKIA_TARGET in
    ;;


It will be good if we can include Angle as a jar via skiko-awt-runtime-angle-$platform

Let me see if I can figure this out

skiko/build-with-local-skia.sh

This fixes the black bars issue when resizing a window

igordmn · 2025-02-19T20:50:42Z

skiko/src/jvmMain/kotlin/org/jetbrains/skiko/SkikoProperties.kt

@@ -127,7 +132,7 @@ object SkikoProperties {
        when(hostOs) {
            OS.MacOS -> return GraphicsApi.METAL
            OS.Linux -> return GraphicsApi.OPENGL
-            OS.Windows -> return GraphicsApi.DIRECT3D
+            OS.Windows -> return GraphicsApi.ANGLE


Skiko without Angle prints an error into console:

[SKIKO] warn: Fallback to next API org.jetbrains.skiko.RenderException: Failed to load ANGLE library: org.jetbrains.skiko.RenderException: Native exception in [Java_org_jetbrains_skiko_AngleSupport_1jvmKt_loadAngleLibraryWindows], code 126: The specified module could not be found.

We should check overhead of loading Angle without dlls.

If it is almost zero - replace RenderException by OptionalRenderApiException : RenderException and ignore it without printing.

Otherwise add something skiko.renderApi.fallbackChain that also specifies the default (first one).

igordmn · 2025-02-19T21:18:35Z

skiko/src/awtMain/kotlin/org/jetbrains/skiko/redrawer/AngleRedrawer.kt

+private external fun disposeDevice(device: Long)
+
+@Suppress("unused")
+class AngleRedrawerException(message: String) : RuntimeException(message)


Why not reuse RenderException?

igordmn · 2025-02-19T21:30:29Z

skiko/src/awtMain/cpp/windows/AngleSupport.cc

+        return eglGetProcAddress(procname);
+    }
+
+    JNIEXPORT jstring JNICALL Java_org_jetbrains_skiko_AngleApi_glGetString(JNIEnv *env, jobject object, jint value)


Better to Move to AngleApi.cc (in the other file too)

igordmn · 2025-02-19T21:36:29Z

skiko/src/commonMain/kotlin/org/jetbrains/skiko/AngleSupport.kt

+package org.jetbrains.skiko
+
+/**
+ * Load OpenGL library into memory.


The Kdoc should be rewritten

igordmn · 2025-02-19T21:41:42Z

skiko/src/awtMain/kotlin/org/jetbrains/skiko/redrawer/AngleRedrawer.kt

+                ?: throw RenderException("Failed to create ANGLE device.")
+        }
+        adapterName.let { adapterName ->
+            if (adapterName == null || !isVideoCardSupported(GraphicsApi.ANGLE, hostOs, adapterName)) {


In the OpenGLRedrawer it is adapterName != null && , just to pass a valid value to isVideoCardSupported, not prohibit null adapterName. Can we use the same logic? Or it is better to have this?

igordmn · 2025-02-19T22:04:09Z

skiko/src/awtMain/cpp/windows/AngleSupport.cc

+        TCHAR libEGL[MAX_PATH] = TEXT("");
+        TCHAR libGLESv2[MAX_PATH] = TEXT("");
+        HMODULE hmodule = nullptr;
+        THROW_IF_NULL(GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS | GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT,


Where should I put dll's in case I run a Java library?

Worked only after I packaging via jpackage, and placing the libs near the jars. But not sure how it should work without it, for example, when I run via Gradle that defines a classpath in different cached folders.

igordmn · 2025-02-19T22:13:42Z

skiko/src/jvmMain/kotlin/org/jetbrains/skiko/SkikoProperties.kt

@@ -139,8 +144,8 @@ object SkikoProperties {
            OS.MacOS -> listOf(GraphicsApi.METAL, GraphicsApi.SOFTWARE_COMPAT)
            OS.Windows -> when (hostArch) {
                // Skia isn't properly tested on OpenGL and Windows ARM (https://groups.google.com/g/skia-discuss/c/McoclAhLpvg?pli=1)
-                Arch.Arm64 -> listOf(GraphicsApi.DIRECT3D, GraphicsApi.SOFTWARE_FAST, GraphicsApi.SOFTWARE_COMPAT)
-                else -> listOf(GraphicsApi.DIRECT3D, GraphicsApi.OPENGL, GraphicsApi.SOFTWARE_FAST, GraphicsApi.SOFTWARE_COMPAT)
+                Arch.Arm64 -> listOf(GraphicsApi.ANGLE, GraphicsApi.DIRECT3D, GraphicsApi.SOFTWARE_FAST, GraphicsApi.SOFTWARE_COMPAT)


Is other OS support planned? I looked at https://skia.org/docs/user/special/angle/, and it seems only Linux additionally mentioned. 4 years ago I thought it was also macOs. Maybe it was deprecated, or I thought wrongly.

igordmn · 2025-02-19T22:30:58Z

skiko/src/awtMain/kotlin/org/jetbrains/skiko/redrawer/AngleRedrawer.kt

+import org.jetbrains.skiko.*
+import org.jetbrains.skiko.context.AngleContextHandler
+
+internal class AngleRedrawer(


I tested FPS manually, and have FPS dropped from 80 to 69 (DIRECT3D -> ANGLE).

I suspected dwmFlush. Removing it, and enabling eglSwapInterval(angleDevice->display, 1) increased FPS to 93.

I think we can use eglSwapInterval here. Because it is not a real opengl, just translated to DirectX, right? When in the past I tested real OpenGL, vsync was unstable with SwapInterval compared to dwmFlush.

There is one catch though, when I maximize the DirectX window, my system somehow optimises this case and increases the FPS (from mentioned 80 to 90).

But with the Angle implementation, this optimisation doesn't work, and FPS decreases from 93 to 77 🤔

Not sure what is this optimization. Prioritisation? Simplified composition? gpu boost? Needs investigation

igordmn · 2025-02-19T23:40:12Z

skiko/src/awtMain/cpp/windows/AngleRedrawer.cc

+            AngleDevice *angleDevice = new AngleDevice();
+            angleDevice->window = hwnd;
+            angleDevice->device = hdc;
+            angleDevice->display = getAngleEGLDisplay(angleDevice->device);


We should test how if FPS always equals refresh rate when we move a window from one display to another with different refresh rate (after removing dwmFlush)

igordmn · 2025-02-19T23:43:19Z

skiko/src/awtMain/cpp/windows/AngleSupport.cc

+        THROW_IF_NULL(LoadLibrary(libGLESv2));
+    }
+}
+


I have d3dcompiler_47.dll already inside my system32 folder. Not sure that it is the same on other systems though.

Works without this one: https://github.com/Alovchin91/angle-pack/releases/tag/7fea539cc9

igordmn self-requested a review January 30, 2025 10:50

igordmn reviewed Jan 31, 2025

View reviewed changes

igordmn self-requested a review January 31, 2025 13:38

Alovchin91 force-pushed the alovchin/angle branch 4 times, most recently from b951351 to 87790e5 Compare February 7, 2025 15:34

Alovchin91 marked this pull request as ready for review February 7, 2025 15:42

Alovchin91 added 4 commits February 12, 2025 11:21

Add infrastructure to support ANGLE in Skiko

bb436d0

Implement AngleRedrawer and AngleContextHandler

096f1cb

Load ANGLE libraries by full path

8ae713a

Recreate the surface instead of resizing

4cf4430

This fixes the black bars issue when resizing a window

Alovchin91 force-pushed the alovchin/angle branch from 87790e5 to 4cf4430 Compare February 12, 2025 10:37

Alovchin91 mentioned this pull request Feb 12, 2025

Enable ANGLE support in Skia-pack JetBrains/skia-pack#65

Draft

igordmn mentioned this pull request Feb 13, 2025

Add a thin wrapper around Skia's PDF backend #775

Open

igordmn reviewed Feb 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ANGLE support #1017

ANGLE support #1017

Alovchin91 commented Jan 30, 2025 •

edited

Loading

igordmn Jan 31, 2025

Alovchin91 Jan 31, 2025 •

edited

Loading

igordmn Feb 19, 2025

igordmn Feb 19, 2025

igordmn Feb 19, 2025

igordmn Feb 19, 2025

igordmn Feb 19, 2025

igordmn Feb 19, 2025

igordmn Feb 19, 2025

igordmn Feb 19, 2025

igordmn Feb 19, 2025

igordmn Feb 19, 2025

igordmn Feb 19, 2025

ANGLE support #1017

Are you sure you want to change the base?

ANGLE support #1017

Conversation

Alovchin91 commented Jan 30, 2025 • edited Loading

Choose a reason for hiding this comment

Alovchin91 Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Alovchin91 commented Jan 30, 2025 •

edited

Loading

Alovchin91 Jan 31, 2025 •

edited

Loading